Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mediawiki 1.33 #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update mediawiki 1.33 #1

wants to merge 4 commits into from

Conversation

Maaiins
Copy link

@Maaiins Maaiins commented Apr 20, 2020

Not yet ready to merge.

First draw of the integration, currently working on it. Feel free to add a review.

@Maaiins Maaiins requested a review from padams April 20, 2020 17:17
@Maaiins
Copy link
Author

Maaiins commented Apr 26, 2020

I've got some trouble...

Owa is installing correctly but all api requests in admin interface of Owa will fail with "Not authenticated". The auth_status filter is not called from owa_auth::authenticateUser. Any ideas?

Log:

04:49:32 2020-04-26 26934 [debug_log] check for http host 
04:49:32 2020-04-26 26934 [debug_log] Setting cookie domain to .media.winhelp.work 
04:49:32 2020-04-26 26934 [debug_log] *** Starting Open Web Analytics vmaster. Running under PHP v7.1.33-nmm1 (Linux) *** 
04:49:32 2020-04-26 26934 [debug_log] Request URL:GET /extensions/Owa/instance/api/index.php?&owa_siteId=f0667e0c008f7015103fe874f514611c&owa_period=last_seven_days&owa_module=base&owa_version=v1&owa_do=reports&owa_metrics=visits,uniqueVisitors,pageViews,bounceRate,pagesPerVisit,visitDuration&owa_dimensions=date&owa_sort=date&owa_format=json 
04:49:32 2020-04-26 26934 [debug_log] User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.122 Safari/537.36 
04:49:32 2020-04-26 26934 [debug_log] Host: media.winhelp.work 
04:49:32 2020-04-26 26934 [debug_log] check cache file: extensions/Owa/instance/owa-data/caches/1/owa_configuration/fafe1b60c24107ccd8f4562213e44849.php 
04:49:32 2020-04-26 26934 [debug_log] CACHE HIT (Cold) - Retrieved Object from Cache File - Collection: owa_configuration, id: fafe1b60c24107ccd8f4562213e44849 
04:49:32 2020-04-26 26934 [debug_log] Caller configuration overrides applied. 
04:49:32 2020-04-26 26934 [debug_log] request container says params are: 
04:49:32 2020-04-26 26934 [debug_log] Array
(
    [owa_siteId] => f0667e0c008f7015103fe874f514611c
    [owa_period] => last_seven_days
    [owa_module] => base
    [owa_version] => v1
    [owa_do] => reports
    [owa_metrics] => visits,uniqueVisitors,pageViews,bounceRate,pagesPerVisit,visitDuration
    [owa_dimensions] => date
    [owa_sort] => date
    [owa_format] => json
)
 
04:49:32 2020-04-26 26934 [debug_log] Filtering register_build_package 
04:49:32 2020-04-26 26934 [debug_log] Filtering register_build_package 
04:49:32 2020-04-26 26934 [debug_log] Filtering register_build_package 
04:49:32 2020-04-26 26934 [debug_log] base Schema version is 9 
04:49:32 2020-04-26 26934 [debug_log] base Required Schema version is 9 
04:49:32 2020-04-26 26934 [debug_log] check cache file: extensions/Owa/instance/owa-data/caches/1/owa_site/3479e2c95bc30a9e50f3f973ff114839.php 
04:49:32 2020-04-26 26934 [debug_log] CACHE HIT (Cold) - Retrieved Object from Cache File - Collection: owa_site, id: 3479e2c95bc30a9e50f3f973ff114839 
04:49:32 2020-04-26 26934 [debug_log] CACHE HIT (Warm) - Retrieved Object from Cache - Collection: owa_site, id: 3479e2c95bc30a9e50f3f973ff114839 
04:49:32 2020-04-26 26934 [debug_log] Getting state - store: u key:  
04:49:32 2020-04-26 26934 [debug_log] Notifying listeners of init 
04:49:32 2020-04-26 26934 [debug_log] no listeners registered for this event type. 
04:49:32 2020-04-26 26934 [debug_log] EHS: Responses - Array
(
)
 
04:49:32 2020-04-26 26934 [debug_log] EHS: Event was handled successfully by all handlers. 
04:49:32 2020-04-26 26934 [debug_log] Handling request with params: Array
(
    [siteId] => f0667e0c008f7015103fe874f514611c
    [period] => last_seven_days
    [module] => base
    [version] => v1
    [do] => reports
    [metrics] => visits,uniqueVisitors,pageViews,bounceRate,pagesPerVisit,visitDuration
    [dimensions] => date
    [sort] => date
    [format] => json
)
 
04:49:32 2020-04-26 26934 [debug_log] Generating REST API route controller... 
04:49:32 2020-04-26 26934 [debug_log] Array
(
    [class_name] => owa_reportsRestController
    [file] => extensions/Owa/instance/modules/base/controllers/reportsRestController.php
    [params] => Array
        (
        )

)
 
04:49:32 2020-04-26 26934 [debug_log] Performing Action: owa_reportsRestController 
04:49:32 2020-04-26 26934 [debug_log] Getting state - store: u key:  
04:49:32 2020-04-26 26934 [debug_log] Could not find any credentials to authenticate with. 
04:49:32 2020-04-26 26934 [debug_log] Filtering auth_status 
04:49:32 2020-04-26 26934 [debug_log] Assembling view: owa_restApiView 
04:49:32 2020-04-26 26934 [debug_log] Total session time: 0.0204348564148 
04:49:32 2020-04-26 26934 [debug_log] goodbye from OWA 
04:49:32 2020-04-26 26934 [debug_log] starting to persist cache... 
04:49:32 2020-04-26 26934 [debug_log] There seem to be no dirty objects in the cache to persist. 
04:49:32 2020-04-26 26934 [debug_log] Cache Statistics: 
                          Total Hits: 3 (Warm/Cold: 1/2)
                          Total Miss: 0
                          Total Added to Cache: 0
                          Total Replaced: 0
                          Total Persisted: 0
                          Total Removed: 0

@Maaiins
Copy link
Author

Maaiins commented Apr 26, 2020

Could this be the solution? https://github.com/Open-Web-Analytics/Open-Web-Analytics/pull/560/files#diff-e26a3d38fffc14f42ffba9e2ecdeae6cR789

@padams
Copy link
Contributor

padams commented Apr 26, 2020

I can take a closer look later but I’m moving the WordPress plugin away from needing OWA installed on the same server.

I’d like to see users always have to do the standalone install and then use an integration plugin to set tracker properties and insert the JavaScript etc.

In terms of showing reporting within mediawiki etc. I’d like to see us get rid of all of that and just link to the standalone OWA endpoints.

A lot of plugins are moving to a pattern where they implement a lightboxed iframe that loads their own endpoints. That my next step for the WP plugin. Once I do that I can prune that autH code and a whole bunch of other stuff 😉

@Maaiins
Copy link
Author

Maaiins commented Apr 27, 2020

Sounds solid. Will wait until you refactored the WP plugin, then i will take a closer look. At the moment i'm interested in how you will track via php.

@Maaiins
Copy link
Author

Maaiins commented May 17, 2020

Hey Peter,
am I wrong or is the wordpress plugin at the moment still only working when there's a local install?

@padams
Copy link
Contributor

padams commented May 17, 2020

Only a local install. I had to do some Other cleanup but will get back to that this week. That said, the SDK is now working as a standalone install!

@Maaiins
Copy link
Author

Maaiins commented May 17, 2020

Oh wow didn't see that, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padams padams Awaiting requested review from padams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maaiins @padams